This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Refactor task middleware with redux-saga #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- includes a few tweaks for Windows support
superhawk610
changed the title
|
Closing in favor of #122. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution!
Please fill out the following template with details about your pull request:
Related Issue #97
Summary
With @mik639's permission, I've refactored the task middleware to use redux-saga. I'm developing from a Windows machine, so I had to use @bennygenel's
windows-supportfork, and there are a few artifacts of that remaining in this code, but I figure the full redux-saga refactor is still a little ways off and with any luck we'll have Windows support merged into the master by then. If you'd like to run this yourself, it should be sufficient to just pull insrc/services/platform.services.jsfrom @bennygenel's repo here.When reviewing, specifically look for my usage of raw synchronous function calls vs
yield call(...)within generators, I'm fairly certain I used them correctly but could use some reassurance. In addition, I had to take an interesting approach to handling stdio channels within generator functions, so I'm curious if mycreateStdioChannelapproach is the best way to go about this.