Error Object, remove unnecessary new keywords, format code
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that the only breaking change would be the |
jossef
requested changes
Oct 19, 2019
| onError.publish(errorEvent); | ||
| throw Exception("Invalid HTTP status code $statusCode for url $url"); | ||
| throw Response(responseContent, statusCode, !hasClientOrServerError); |
There was a problem hiding this comment.
I prefer to throw a custom exception with all data in his instance
throw HTTPException(message, statusCode, responseContent)
jossef
reviewed
Oct 19, 2019
| try { | ||
| await Requests.get('$PLACEHOLDER_PROVIDER/api/unknown/23', | ||
| shouldThrow: true); | ||
| } catch (resp) { |
There was a problem hiding this comment.
and here I would catch the specific custom exception and read the data stored on his instance
Suggested change
| } catch (resp) { | |
| } on HTTPException catch (e) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adresses Issue #9 .
I've changed the json dummy provider to https://reqres.in/
Removed unnecessary
newkeyword: Don't use newFormatting code with dartfmt
Added:
bool→ Default:true(whether the request should throw an error with theRequestobject, the default istrueto keep minimum compatibility)bool→ Default:true(whether the request should return only the response and not theRequestobject, the default istrueto keep minimum compatibility)