feat: replace stash_hive
with quiver.cache
#68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use
quiver.cache
instead ofstash_hive
and remove encryption.Type of changes
What types of changes does your code introduce?
Checklist
Further comments
I've replaced
stash_hive
forquiver.cache
as there isn't the need for hard storing the cookies, and storing the cookies in the drive might cause more problem than solving some: IO issues, when 2 programs are looking at the same storage file...As @LightIn-death and I said previously in #1, storing sensitive data in cookies is a really bad practice. Yet, I have accepted #65 as
requests
usedhive
to store its cookies and it would be dumb to not use its native encryption.But there is a better alternative and it is to store the cookies in memory. If the end user wants to save the cookies for some next runs, this will be up to him to do that.
And also, if someone wants to implement
requests
into a flutter project, surely they will use their own storage system likeflutter_secure_storage
orshared_prefrences
, and I don't think it would be good to have 2 different storage systems.