Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace stash_hive with quiver.cache #68

Merged
merged 4 commits into from
May 10, 2022
Merged

feat: replace stash_hive with quiver.cache #68

merged 4 commits into from
May 10, 2022

Conversation

sehnryr
Copy link
Collaborator

@sehnryr sehnryr commented May 9, 2022

Proposed changes

Use quiver.cache instead of stash_hive and remove encryption.

Type of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • My code follows the Dart coding convention
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary documentation (if appropriate)

Further comments

I've replaced stash_hive for quiver.cache as there isn't the need for hard storing the cookies, and storing the cookies in the drive might cause more problem than solving some: IO issues, when 2 programs are looking at the same storage file...

As @LightIn-death and I said previously in #1, storing sensitive data in cookies is a really bad practice. Yet, I have accepted #65 as requests used hive to store its cookies and it would be dumb to not use its native encryption.

But there is a better alternative and it is to store the cookies in memory. If the end user wants to save the cookies for some next runs, this will be up to him to do that.

And also, if someone wants to implement requests into a flutter project, surely they will use their own storage system like flutter_secure_storage or shared_prefrences, and I don't think it would be good to have 2 different storage systems.

@sehnryr sehnryr marked this pull request as ready for review May 9, 2022 22:28
@sehnryr sehnryr changed the title feat: replace stash hive with quiver feat: replace stash_hive with quiver.cache May 10, 2022
@sehnryr sehnryr merged commit d6b4c53 into jossef:master May 10, 2022
@sehnryr sehnryr deleted the quiver-cache branch May 10, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant