Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional captions to be shown in the Lightbox #12

Merged
merged 5 commits into from
Dec 7, 2015

Conversation

ko
Copy link
Contributor

@ko ko commented Dec 7, 2015

This adds a possible 'caption' property to the elements within an 'images' list.

Testing with the generated examples page shows that it is backward compatible for those who do not provide captions. This can be seen in the first 3 images of the first Gallery within examples/src/app.js--as described in the updated README.

jossmac added a commit that referenced this pull request Dec 7, 2015
Adding optional captions to be shown in the Lightbox
@jossmac jossmac merged commit 10d2ab1 into jossmac:master Dec 7, 2015
@jossmac
Copy link
Owner

jossmac commented Dec 7, 2015

This is great, thank you @ko

I really appreciate you updating the README also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants