Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python3 #71

Closed
josuebrunel opened this issue May 13, 2015 · 2 comments
Closed

Add support for Python3 #71

josuebrunel opened this issue May 13, 2015 · 2 comments
Assignees
@josuebrunel
Labels
enhancement help wanted
Milestone
1.2.2

Comments

@josuebrunel
Copy link
Owner

_mYQL_ must support _Python3_
@josuebrunel josuebrunel self-assigned this May 13, 2015
@josuebrunel josuebrunel added this to the 2.0 milestone May 13, 2015
@josuebrunel
Copy link
Owner Author

Documentation is here

Explicit relative import

from tests import TestClass # Bad
...
from .tests import TestClass # Good

But seriously, absolute import is the thing.

from __future__ import absolute_import

Exception handling

except Exception, e: # Bad
...
except (Exception,) as e: # Good

Unittest

self.assertEquals # Bad
...
self.assertEqual # Good

josuebrunel added a commit that referenced this issue May 19, 2015
@josuebrunel
#71: Turning exception into Python3 exceptions
b9a7669
josuebrunel added a commit that referenced this issue May 19, 2015
@josuebrunel
#71: running toward python3
29f9a38
@josuebrunel
Copy link
Owner Author

change-in-import-handling-modules-from-python2-to-python3 👍

josuebrunel added a commit that referenced this issue May 22, 2015
@josuebrunel
#71 : json issues fixed
e3ea23c
josuebrunel added a commit that referenced this issue May 22, 2015
@josuebrunel
#71: json_write_data and json_get_data function added to utils
6d274ac
josuebrunel added a commit that referenced this issue May 22, 2015
@josuebrunel
#71: use of myql utils functions
ede585e
josuebrunel added a commit that referenced this issue May 22, 2015
@josuebrunel
#71: travis tests for py27 and py32
2329fb9
josuebrunel added a commit that referenced this issue May 22, 2015
@josuebrunel
#71: requirements updated
9b55e8b
josuebrunel added a commit that referenced this issue May 22, 2015
@josuebrunel
#71: absolute import used
2bd7624
josuebrunel added a commit that referenced this issue May 22, 2015
@josuebrunel
#71: python3.2 added
5fa347e
@josuebrunel josuebrunel modified the milestones: 1.2.2, 2.0 May 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josuebrunel josuebrunel

Labels
enhancement help wanted
Projects
None yet
Milestone
1.2.2
Development

No branches or pull requests
1 participant
@josuebrunel