Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Microbundle compat bundler and React based jotai utils core #27

Merged
merged 4 commits into from
Apr 13, 2024

Conversation

barelyhuman
Copy link
Collaborator

@barelyhuman barelyhuman commented Apr 13, 2024

Requirements

  • Update base version to 18
  • Add in the base layer to support react specific utilities for jotai-form

@barelyhuman barelyhuman self-assigned this Apr 13, 2024
Copy link

codesandbox-ci bot commented Apr 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Member

dai-shi commented Apr 13, 2024

In case you are concerned, I don't think we need to keep UMD compatibility if it causes too much trouble. ESM and CJS would probably be okay.

@barelyhuman
Copy link
Collaborator Author

Makes sense, already wrote it though, and there's not much to do there.
I just needed to be able to modify rollup's config to allow simple multi entry builds which seems to be a pain with microbundle.

@barelyhuman
Copy link
Collaborator Author

Validated the existing exports and types work on new project using vite.

@barelyhuman barelyhuman merged commit ce67123 into main Apr 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants