Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix result of statusAtom sometimes not updated #35

Merged
merged 2 commits into from
May 24, 2023
Merged

Fix result of statusAtom sometimes not updated #35

merged 2 commits into from
May 24, 2023

Conversation

V-Mann-Nick
Copy link
Contributor

@V-Mann-Nick V-Mann-Nick commented May 23, 2023 •
edited
Loading

Fixes #34

Tests are all passing.

I've implemented one test which failed before the fix.

@V-Mann-Nick V-Mann-Nick changed the title Fix result not updated Fix result of statusAtom sometimes not updated May 23, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 23, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit feae268:

Sandbox Source
React Configuration
React Typescript Configuration
jotai-query-bug-reproduction Issue #34

@dai-shi
Copy link
Member

dai-shi commented May 23, 2023

Can you merge the main branch please?

@V-Mann-Nick
Copy link
Contributor Author

I've rebased on top of main.

dai-shi
dai-shi approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(It may or may not change the behavior of dataAtom, but should be okay anyway.)

@dai-shi dai-shi merged commit b348b2c into jotaijs:main May 24, 2023
@dai-shi
Copy link
Member

dai-shi commented May 24, 2023

Published: https://www.npmjs.com/package/jotai-tanstack-query/v/0.7.1

@V-Mann-Nick
Copy link
Contributor Author

Thanks a lot.

@V-Mann-Nick V-Mann-Nick deleted the fix-result-not-updated branch May 25, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cached observer with cached result does not update statusAtom
2 participants
@V-Mann-Nick @dai-shi