Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role binding to the template definition #3

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

simonpasquier
Copy link
Contributor

This avoids invoking the 'oc adm' CLI although it requires to pass the
current namespace as a parameter when launching the app.

Not sure if you think it is a improvement, feel free to merge or reject ;-)

This avoids invoking the 'oc adm' CLI although it requires to pass the
current namespace as a parameter when launching the app.
@jotak
Copy link
Owner

jotak commented Nov 27, 2017

I like it, it's definitely faster 👍
I just wonder if it's possible to use the downward API at this position, to make it even better? I know about metadata.namespace that we can interpolate in container arguments, but not sure if we can do it in role bindings.

@simonpasquier
Copy link
Contributor Author

Unfortunately this isn't possible, see openshift/origin#8971 (comment).

@jotak jotak merged commit 30f702b into jotak:master Nov 28, 2017
@jotak
Copy link
Owner

jotak commented Nov 28, 2017

Thanks @simonpasquier !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants