-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gapseq's sbml in memote #42
Comments
Dear @hites77, I will look into this issue. Would it be possible for you, to share your model ('TelongatusBP-1.xml')? If you wish, you can also send it to s.waschina[at]nutrinf.uni-kiel.de Best |
I have mailed you the model file |
The main problem why memote failed is due to a mistake in the sbml header: In line 2: Here, the argument
Addtionally, line 3 misses the id argument. It should look something like this:
In our tests of gapseq, the two aboved mentioned arguements are added automatically in the reconstruction process. Hence, it might be an issue of different versions of libsbml and/or the R-Package "sybilSBML". Could you maybe check the version numbers? In my tests I used libsbml version 5.18.0 and sybilSBML version 3.1.2. |
Thanks for the response. I am using the libsbml version 5.17.0 and sybilSBML version 3.0.1. So for other model I have to edit the lines as you have mentioned and it will run in memote and cobratoolbox ? I checked the model you have send me in memote using command : memote report snapshot --skip test_find_metabolites_not_produced_with_open_bounds --skip test_find_metabolites_not_consumed_with_open_bounds TelongatusBP-1.xml The score comes out to be 77% however there is error in Biomass consistency (under Biomass heading). |
HI, While checking memote detail report I found following issues that can be checked: In Charge Balance it report issue: In Unbounded Flux In Default Medium it reports: this are very important parameter , so please have a look and suggest |
Manually editing the xml files would work, but I recommend updating the sybilSBML version to 3.1.2 instead and manual xml-editing will not be necessary. Install instructions for the R-Package can be found on sybilSBML's CRAN page. Concerning the memote output you mentioned, I am currently working on the corrections. Thank you for your help! Best wishes |
Sure I will try to update and check the output. |
The commit 297a633 repaired a number of inconsistencies that memote found (see above). We will correct more as we identify them. I will close this issue here for now, as gapseq's sbml models should be compatible with memote now (at least with the latest version of sybilSBML). But please reopen in case errors of gapseq models in memote pop up. @hites77 Thank you for your help and feedback. |
Hi, So I try to build a new GMM for one of the genome with latest update from gapseq and also latest sybilSBML and found that now Charge and Mass balance score to 100% in memote (Good updates in gapseq), but the Unbounded Flux In Default Medium score only 63.7 %. also Memote report that there were 28 Duplicate Metabolites in Identical Compartments. |
I am glad the charge and mass balance scores of reactions are better now. And we are aware of the memote's notes on the biomass and unbounded fluxes. In fact, we are working on this already and will mention this issue in the commits that will fix those problems as soon as we implemented a tidy solution. |
Hi, ACP (Acyl-Carrier-Protein, id: cpd11493, formula: C11H21N2O7PRS) Per unit of ACP-consumed by the biomass reaction, produces the same molar amount of apo-ACP (inactive form of ACP, id: cpd12370, formula: HOR) This handling of ACP enables that the biochemical modification of the ACP-protein that are require to activate ACP are also part of the biomass reaction and the FBA solution includes also the important metabolic reactions for ACP activation. I hope this illustrates the underlying causes of memote's error output and the consistency of ModelSEED's and gapseq's biomass reactions. Concerning the other issue you mentioned: we are on it :) Thanks again for your help! |
Hi, Congratulations for your recent gapseq publications What I want to mention is that for my metabolic model after gapfilling and running memote I am getting 65% unbounded flux , and hundreds of dead end metabolites. So, is there any way to solve this issue ? |
Hi, jotech, thanks for providing that media file, seems that composition of my media was wrong, now the growth rate is 0.056.
However now the xml file generated is showing valid by sbml validator but it shows following warning:
Warning: As a principle of best modeling practice, the should set an initial value (amount or concentration) rather than be left undefined. Doing so improves the portability of models between different simulation and analysis systems, and helps make it easier to detect potential errors in models. The with the id 'M_cpd00001_c0' does not have an 'initialConcentration' or 'initialAmount' attribute, nor is its initial value set by an or .
Also when I try to run in memote it shows following error which was not being shown previously
critical: The model could not be loaded due to the following SBML errors.
error: Something went wrong reading the SBML model. Most likely the SBML model is not valid. Please check that your model is valid using the
cobra.io.sbml.validate_sbml_model
function or via the online validator at http://sbml.org/validator .error:
(model, errors) = validate_sbml_model(filename)
error: If the model is valid and cannot be read please open an issue at https://github.com/opencobra/cobrapy/issues .
error: Line 2, Column 0 - #1013: Invalid or undefined XML namespace prefix.
error: - Category: XML content, Severity: 2
the error occur even when I do a fresh install of memote in new virtual environment.
I also check with cobra validation command cobra.io.sbml.validate_sbml_model('TelongatusBP-1.xml')
and it give following error
(None, {'SBML_FATAL': [], 'SBML_ERROR': ['E0 (Error): XML content (core, L2); Bad XML prefix; Invalid or undefined XML namespace prefix.\n'], 'SBML_SCHEMA_ERROR': [], 'SBML_WARNING': [], 'COBRA_FATAL': [], 'COBRA_ERROR': ['No SBML model detected in file.'], 'COBRA_WARNING': [], 'COBRA_CHECK': []})
Originally posted by @hites77 in #41 (comment)
The text was updated successfully, but these errors were encountered: