Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use alias of NlpJsEntity instead of entity as name if possible #1158

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

m-ripper
Copy link
Contributor

Proposed changes

  • Use alias of NlpJsEntity as name of the entity if set.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@m-ripper m-ripper changed the base branch from v4/latest to v4/dev December 14, 2021 11:38
@m-ripper m-ripper changed the title ✨ Use alias of NlpJsEntity instead of entity as name if possible ✨ Use alias of NlpJsEntity instead of entity as name if possible Dec 14, 2021
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I just updated the docs a bit as well ✅

@m-ripper m-ripper merged commit 6b5f411 into v4/dev Dec 15, 2021
@m-ripper m-ripper deleted the v4/improvement/nlpjs-entity-alias branch December 15, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants