Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix incorrect localeId for Lex #1330

Merged
merged 2 commits into from
May 31, 2022
Merged

🐛 Fix incorrect localeId for Lex #1330

merged 2 commits into from
May 31, 2022

Conversation

rmtuckerphx
Copy link
Contributor

Proposed Changes

Adds a localeMap configuration to Lex to allow mapping of a request locale to a Lex localeId.

Fix for #1260

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow
Copy link
Member

Thanks!

jankoenig
jankoenig approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Also for updating the docs, this is very helpful 🎉

@aswetlow aswetlow merged commit 8b021ab into jovotech:v4/dev May 31, 2022
@aswetlow aswetlow mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

@aswetlow aswetlow aswetlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmtuckerphx @aswetlow @jankoenig