Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Google Optimize support #876

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Conversation

theBenForce
Copy link
Contributor

Proposed changes

Allows developers to provide specific Google Analytics parameters, and easily provide details for Google Optimize experiments. This is accomplished by adding the $parameters object to google analytics which is used when constructing the pageview parameters.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow
Copy link
Member

Thank you!!!

@aswetlow aswetlow merged commit bb484f2 into jovotech:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants