Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics: Custom Metrics and Dimensions supporting names + validation #910

Merged
merged 21 commits into from
Mar 26, 2021
Merged

Conversation

freiSMS
Copy link
Contributor

@freiSMS freiSMS commented Mar 9, 2021

Proposed changes

  • Allow developers to define the index of google Analytics metrics and dimensions set by system (see here https://community.jovo.tech/t/google-analytics-custom-dimension-metrics-improvements/1510?u=andre)
    • fixes problem of overwriting developers custom definitions
    • readable code -> instead of setting "cd1" your are setting custom dimension 'UUID'
    • allow changing target custom definition without changing code logic
  • Add "strict mode" via config -> will check if all needed system definitions are defined + are not mapped to same index
  • make $googleAnalytics instance of class
    • -> gives access to features of used universal-analytics
    • -> enhance class with new method will no longer need second declaration on $googleAnalytics object and third definition on interface

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow merged commit 2f2d845 into jovotech:master Mar 26, 2021
@aswetlow
Copy link
Member

Thank you so much, André

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants