luci2-ui-base: fix l2.cgi.js validation messages #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit looks wrong to me, what you're actually fixing here? |
|
When the input will be validated then i want to see the range or min/max values what the input expects.
|
|
Ok but then use the format function to interpolate values: |
feckert
force-pushed
the
fix_l2cgi_validation_messages
branch
from
b7c096f
to
ff9c54f
Compare
Signed-off-by: Florian Eckert <Eckert.Florian@googlemail.com>
feckert
force-pushed
the
fix_l2cgi_validation_messages
branch
from
ff9c54f
to
6fb62a8
Compare
|
Merged manually with two tiny white space changes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Florian Eckert Eckert.Florian@googlemail.com