RFC: use node/gulp as build system #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think gulp is a great idea. @ianchi seems you are no longer supporting this argument, can I ask why? |
|
Sorry, I forgot to leave a notice before closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jow-
This a RFC to use Node.js/Gulp as the build system for the web frontend.
It includes changes on dependencies and Makefiles, and only a stub for the gulpfile.
Not much of the potential is yet used, until we agree on a direction, as some more changes are needed.
The only actual functionality added so far is a web server for development with a proxy that forwards RPC's to the router. Useful for quick testing.
Many more functionalities could easily be added to this schema: linting / concatenation + minification of js / add prefixes to css / use templateCache to develop directives in Html and later convert to js (much easier to edit) ....
I think that it would be best to slightly change the folder structure. For this RFC I only solved it with a symlink, but a more permanent definition is needed before merging this.
With this proposed structure, Gulp can be manually used first on the "src" folders while developing, and later again by the LEDE make process to generate the final package.
I'll be sending a separate PR to the Packages repo to update the Nodejs version to the current LTS one.
Signed-off-by: Adrian Panella ianchi74@outlook.com