RFC: Tabbed Navigation #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add navTabs component for tabbed navigation of menues. Signed-off-by: Adrian Panella <ianchi74@outlook.com>
Add functionality to use tabbed navigation of menues. Add example menu definition. Signed-off-by: Adrian Panella <ianchi74@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tabbed navigation for (last) level of menu definition.
Tabs are defined using the current menu.d approach, so all the validation of acl's and files still aplies.
The idea is to have fixed "Status | Basic | Advanced" tabs, but the logic is flexible to what is actually defined in the menu.
The tabs are rendered at the level where the property "tabbed" is set to 'true'.
Still pending to modify the Breadcrumbs to not repeat the last state, already shown by the tab.