luci2-ui-base: conditional node/host dependency #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add host dependency on Node only if it is not installed (or version prior to 4). This will avoid a lengthy and space consuming compilation. Signed-off-by: Adrian Panella <ianchi74@outlook.com>
|
Solved by e690ddc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jow- I'm no expert at Bash/Makefiles, but I was trying something like this to conditionally
add host dependency on Node only if it is not installed (or version prior to 4).
The idea was to avoid a lengthy and space consuming compilation.
But it doesn't seem to work. The host dependency is compiled anyway after a
make cleanAny ideas or suggestions? Is there a more "natural" way of achieving this in LEDE's build system?