-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If processor
in the device report is no longer to be used by any validations, it should be removed from the json schema.
The version
attribute should be incremented for both validation modules affected here, to be consistent with conventions previously established (consequential changes in code should be indicated by a new version). The database then needs to be updated -- you might as well add on to the add_drive_validations
command I just created in #626: set deactivated
on the updated validations, then when the new rows are added to the validation
table, add those new rows to the Server plan.
Dale pointed out in chat how we can pull the memory total from the dimms array.
54056a9
to
92f63a3
Compare
8704a49
to
75dd29c
Compare
75dd29c
to
2b5483a
Compare
The Device Report sends up a
dimms
and acpus
properties that list the memory DIMMs and the CPUs respectively. These were intended to replace the oldermemory
andprocessor
properties.This PR updates the
DIMMCount
andCPUCount
validations to use the newer properties instead of the older one. This entirely deprecatesprocessors
and leaves the only thetotal
property being used from the object in thememory
property (which currently has no analog in DIMMs).