Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

oio_accept() should require oio_tcp_handle_init() called before #13

Closed
ry opened this issue Apr 18, 2011 · 4 comments
Closed

oio_accept() should require oio_tcp_handle_init() called before #13

ry opened this issue Apr 18, 2011 · 4 comments
Assignees
@ry

Comments

@ry
Copy link
Contributor

ry commented Apr 18, 2011

because it makes the system much simpler on unix
@ry
Copy link
Contributor Author

ry commented Apr 18, 2011

test changed in 2ba25c8

@ry ry closed this as completed in d546a31 Apr 18, 2011
@piscisaureus piscisaureus reopened this Apr 18, 2011
@piscisaureus
Copy link

Isn't it possible to do call tcp_handle_init implicity from oio_accept on linux?
On windows this complicates stuff because socket options are set and iocp association is made in tcp_handle_init.
That work is wasted when you call oio_accept because the accepted socket is a different one.

@ry ry reopened this Apr 18, 2011
@ry
Copy link
Contributor Author

ry commented Apr 18, 2011

ok - i can do.

@ghost ghost assigned ry Apr 18, 2011
@ry ry closed this as completed Apr 18, 2011
@ry
Copy link
Contributor Author

ry commented Apr 18, 2011

did a force push just then. the actual fixing commit is c3eda7a

bigeasy pushed a commit to bigeasy/libuv that referenced this issue Apr 20, 2011
@ry
oio_tcp_handle_accept() does not require initialization of client
c3eda7a 
closes joyent#13.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ry ry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ry @piscisaureus