Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

remove some of these unnecessary status codes and int return values #40

Closed
ry opened this issue May 17, 2011 · 2 comments
Closed

remove some of these unnecessary status codes and int return values #40

ry opened this issue May 17, 2011 · 2 comments
Labels

Comments

@ry
Copy link
Contributor

ry commented May 17, 2011

e.g on the uv_loop_cb

what else?

@piscisaureus
Copy link

uv_async_cb has the same useless status code.

On windows uv_prepare|check|idle|timer_init can never fail, I don't know about unix.

On windows ev_timer_start can fail if the btree is in inconsistent state. However I kill the loop if that happens, because it would probably mean that there is a bug in libuv or the user specified a nonexisting handle.

We need to think about what checks uv functions do. E.g. do they check if the handle type is correct, do they check if the handle isn't closing, do they check if the socket is connected when doing a read, does it check whether a req is improperly reused?

@saghul
Copy link
Contributor

saghul commented Mar 17, 2014

#1190 landed, closing... :-)

@saghul saghul closed this as completed Mar 17, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants