Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
remove some of these unnecessary status codes and int return values #40
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
uv_async_cb has the same useless status code.
On windows uv_prepare|check|idle|timer_init can never fail, I don't know about unix.
On windows ev_timer_start can fail if the btree is in inconsistent state. However I kill the loop if that happens, because it would probably mean that there is a bug in libuv or the user specified a nonexisting handle.
We need to think about what checks uv functions do. E.g. do they check if the handle type is correct, do they check if the handle isn't closing, do they check if the socket is connected when doing a read, does it check whether a req is improperly reused?