unix, windows: removed unused status parameter

[saghul]

async, timer, prepare, idle and check handles don't need the status parameter.

So, this closes issue #40.

I understand this will require many changes on dependant projects (mine included), but I'd go for it because it's just more correct. Also changes are pretty simple :-)

Now, since we seem to be pretty close to v0.12, we could merge this after, I'd also be ok with that.

/cc @indutny, @piscisaureus, @bnoordhuis

[Nodejs-Jenkins]

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

The following commiters were not found in the CLA:

• Saúl Ibarra Corretgé

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

[indutny]

Let's do it after v0.12, I'd like to have some space for ABI trickery :P

[saghul]

On 03/11/2014 09:22 AM, Fedor Indutny wrote:

Let's do it after v0.12, I'd like to have some space for ABI trickery :P

---

Reply to this email directly or view it on GitHub:
#1190 (comment)

Sure, I just wanted to get it out there and get some early feedback.
Look at the branch name ;-)

Saúl Ibarra Corretgé
bettercallsaghul.com

[indutny]

Haha, ok. Looks good.

[bnoordhuis]

FWIW, I have no qualms about landing it before v0.12 but I don't have a strong opinion either. The delta between v0.10 and v0.12 is already huge so a few more changes is just another drop in the ocean. PR LGTM BTW.

[saghul]

On 03/11/2014 05:15 PM, Ben Noordhuis wrote:

FWIW, I have no qualms about landing it before v0.12 but I don't have a
strong opinion either. The delta between v0.10 and v0.12 is already huge
so a few more changes is just another drop in the ocean. PR LGTM BTW.

I just wanted to be cautious and not put work in other's shoulders. Now,
I wouldn't mind landing it before 0.12 (in fact I'd love to) and making
the required changes to Node, if @tjfontaine is ok with that.

Saúl Ibarra Corretgé
bettercallsaghul.com

[saghul]

Here is the companion node PR: nodejs/node-v0.x-archive#7298

[saghul]

Thanks for the comments, it landed! Let there be dragons!