This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Make url.query consistent between slow & fast path #8451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! Would you mind updating the URL docs to reflect that the |
| @@ -136,6 +136,10 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost) { | |||
| } else { | |||
| this.query = this.search.substr(1); | |||
| } | |||
| } else if (parseQueryString) { | |||
| // https://github.com/joyent/node/issues/8332 | |||
There was a problem hiding this comment.
Please remove the link. Any needed information about why this code was introduced can be viewed via git blame and looking at the commit log.
|
@gwicke Here's an example diff for the doc change: diff --git a/doc/api/url.markdown b/doc/api/url.markdown
index e6a43f7..679f6f1 100644
--- a/doc/api/url.markdown
+++ b/doc/api/url.markdown
@@ -69,8 +69,9 @@ The following methods are provided by the URL module:
Take a URL string, and return an object.
-Pass `true` as the second argument to also parse
-the query string using the `querystring` module.
+Pass `true` as the second argument to also parse the query string using the
+`querystring` module. If `true` then the `query` property will always be
+assigned an object.
Defaults to `false`.
Pass `true` as the third argument to treat `//foo/bar` asDo that and we'll throw this on. |
Match the behavior of the slow path by setting url.query to an empty object when the url contains no query, but query parsing is requested. Also add a test for this case, and update the documents to clearly reflect this behavior. issue: nodejs#8332
|
Also mentioned the |
|
Thanks. Merged in b705b73. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the behavior of the slow path by setting url.query to an empty object
when the url contains no query, but query parsing is requested.
Also add a test for this case.
issue: #8332