Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrange widget groups in portrait mode #71

Closed
joyhughes opened this issue Apr 23, 2024 · 9 comments
Closed

Arrange widget groups in portrait mode #71

joyhughes opened this issue Apr 23, 2024 · 9 comments
Assignees
Labels
bug Something isn't working critical critical task enhancement New feature or request gssoc Available for credit in gssoc program level3 Level 3 issue in GSSOC program question Further information is requested UI Involves the user interface
Milestone

Comments

@joyhughes
Copy link
Owner

Arrange widgets in the interface container when it is positioned below the image port.

Question: how to arrange the horizontal widgets in a horizontal container?

Some design work may be necessary

@joyhughes joyhughes added enhancement New feature or request question Further information is requested UI Involves the user interface labels Apr 23, 2024
@joyhughes joyhughes added this to the Alpha release milestone Apr 25, 2024
@joyhughes joyhughes added the bug Something isn't working label Apr 28, 2024
@agxmbedi
Copy link

I am Agamjot singh. Under GSSOC'24, I would like to work on this issue. Pls assign me this!!

@joyhughes
Copy link
Owner Author

I am Agamjot singh. Under GSSOC'24, I would like to work on this issue. Pls assign me this!!

This is probably my most critical issue. Please let me know why you're the best person to take it on quickly.

In particular, what is your familiarity with React and MUI?

@agxmbedi
Copy link

agxmbedi commented May 11, 2024 via email

@joyhughes
Copy link
Owner Author

@agxmbedi Okay let's try. Here's what I think: all the widgets need to go into a grid that fits within the control panel (ControlPanel.js). If there are too many to fit, a scroll bar must be included so they don't overflow.

The control panel can go to the right of the ImagePort or below, depending on the aspect ratios of the image port and the window. Right now it can overflow and wind up to the right when it should be below.

The grid must handle the widgets individually - the problem I am having might be that each widget group goes within its own div. But really we need to have a list of individual widgets, concatenated from the title, the medial controller, and all the widget groups. Then these can all be displayed together in a grid that doesn't overflow.

To complicate things a bit more, the widgets can have different heights but are the same width. So maybe display them in columns - when a column gets full, go to the next column. If more columns are needed than fit within the width of the control panel, include a scroll bar to scroll left to right.

Maybe there is a better way to do this and you have a better idea - do let me know and try it out if this is the case!

@joyhughes joyhughes added gssoc Available for credit in gssoc program level3 Level 3 issue in GSSOC program critical critical task labels May 14, 2024
@joyhughes
Copy link
Owner Author

@agxmbedi
Learn more about project here: https://www.youtube.com/watch?v=vN1ApdESIrc
Please ask any questions you may have

@joyhughes
Copy link
Owner Author

Please join Lux Vitae discord https://discord.gg/GQQHUbkf

@joyhughes joyhughes self-assigned this May 29, 2024
@joyhughes
Copy link
Owner Author

@agxmbedi I am ready to work with you on this issue. I have created branch https://github.com/joyhughes/Jen/tree/UI-layout for this issue and I'll let you know whatever changes I decide to make.

@joyhughes
Copy link
Owner Author

With the latest commit layout flow works in landscape mode but height is incorrect in portrait mode, leading to unused space.

To calculate properly I will be moving responsibility for calculating the size of image port and control panel to InterfaceContainer.js ... then the full window will be used.

@joyhughes
Copy link
Owner Author

I committed again and got the control panel to fill the whole window and the UI elements to arrange automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical critical task enhancement New feature or request gssoc Available for credit in gssoc program level3 Level 3 issue in GSSOC program question Further information is requested UI Involves the user interface
Projects
None yet
Development

No branches or pull requests

2 participants