NVML: Implement NvAPI_GPU_GetGpuCoreCount
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp7677
requested changes
Jun 25, 2022
There was a problem hiding this comment.
Could you please add calls to GetGpuCoreCount here as well https://github.com/jp7677/dxvk-nvapi/blob/master/tests/nvapi_sysinfo.cpp#L1127 for testing the behavior without nvml and variations of that?
Otherwise all good!
|
Like this? |
jp7677
approved these changes
Jun 25, 2022
|
Yes! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least Immortals Fenyx Rising and Assassin's Creed Valhalla call this function, though I have no idea what for. In case of the former, I can't tell any difference (but hey, at least the game still works!) and in case of the latter, I can't check it because Valhalla seems to be utterly broken on NV r515 for unrelated reasons 🙃