Require tweak #280
Merged
Require tweak #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
force-pushed
the
require-tweak
branch
2 times, most recently
from
679938c
to
4fa58b2
Compare
jpadilla
requested changes
Oct 19, 2017
psafont
force-pushed
the
require-tweak
branch
from
4fa58b2
to
5f7be20
Compare
|
Don't know why it's failing, hopefully I didn't mess the rebase. |
jpadilla
approved these changes
Oct 19, 2017
psafont
force-pushed
the
require-tweak
branch
from
5f7be20
to
b894d78
Compare
|
Just in case it was missed, I've rebased it again. |
mark-adams
suggested changes
Nov 25, 2017
psafont
force-pushed
the
require-tweak
branch
from
b894d78
to
64ae4d8
Compare
|
@mark-adams It's been quite a while since the last changes, is something else needed to accept these changes? This functionality would still simplify my code :) |
|
Bump. I would also like to see this functionality released. |
psafont
force-pushed
the
require-tweak
branch
from
64ae4d8
to
2130d36
Compare
|
Rebased patchset to master. Is there anything missing? |
Deprecate the use of the boolean options
psafont
force-pushed
the
require-tweak
branch
from
c690925
to
1e6f1a3
Compare
|
thanks for your patience! |
jpadilla
pushed a commit
that referenced
this pull request
Jun 19, 2020
* Use require options as a list, instead of booleans Deprecate the use of the boolean options * Add test for the new require option * Add documentation on how to use the require option Co-authored-by: Pau Ruiz i Safont <psafont@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes ahead with the proposal in #279
Added a test and documentation on how to use the new parameter.
I took the liberty to deprecate the 'verify_xxx' options while still allowing them (as evidenced by the existing tests)
Feel free to critique any of the changes.