Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checking against multiple issuers #308

Closed
wants to merge 2 commits into from

Conversation

jquense
Copy link

@jquense jquense commented Nov 20, 2017

👋 hey there. This is a compliment to PR #306 it adds support for checking against multiple issuers. Our use-case is to enabling rolling migrations from one auth provider to another, where the audience but also the issuer has changed, without breaking verification for already issued tokens.

cc @yodaiken

@coveralls
Copy link

coveralls commented Nov 20, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 6469397 on jquense:add-iss-as-list into c1253ec on jpadilla:master.

@coveralls
Copy link

coveralls commented Nov 22, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling fa9b5b2 on jquense:add-iss-as-list into c1253ec on jpadilla:master.

@taion
Copy link

taion commented Nov 28, 2017

Any update here? This seems like a pretty innocuous change, and it would simplify life for us.

Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We still need to update docs and changelog.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2a659cb on jquense:add-iss-as-list into e0aa10e on jpadilla:master.

@jquense jquense closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants