Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return tokens as string not bytes #513

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Return tokens as string not bytes #513

merged 1 commit into from
Aug 24, 2020

Conversation

jpadilla
Copy link
Owner

Extracted from #470

@auvipy auvipy merged commit 5d33b04 into master Aug 24, 2020
@auvipy auvipy deleted the string-tokens branch August 24, 2020 10:09
@jpadilla jpadilla added this to the v2.0.0 milestone Sep 1, 2020
@mato2000
Copy link

Hello, I would like to know why tokens was changed to be string instead of bytes. It seems to me that it is more suitable to be bytes. Thanks

@personalcomputer
Copy link

personalcomputer commented Dec 29, 2020

Hi @jpadilla, thanks for all your work on PyJWT. Just as a quick bit a feedback, I want to let you know that this return type
change from bytes to str is a breaking change. Updating to 2.0.0 caused all our code interacting with encode() to fail, as our code has been expecting bytes in return. It was hard to identify what happened as the release notes had listed this item embedded alongside all the other internal changes. It would be helpful that when publishing a new release, to prominently mention breaking API changes in the release notes, so that we can easily see them and update our code to support the changed interface when updating the library. Not required though, just thought I would let you know.
Hey whoops - Looks like you've fixed this in the CHANGELOG.md. Just was missing in the notes in the Github Releases page. My bad that we missed to read the CHANGELOG.md. https://github.com/jpadilla/pyjwt/pull/584/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants