Revert "Remove arbitrary kwargs." #701

auvipy · 2021-10-12T06:32:32Z

Reverts #657

This reverts commit 5fe7f2b.

auvipy · 2021-10-12T06:33:09Z

we should do this in a major version like v3.0

Luctia · 2021-10-12T12:43:00Z

I disagree. If this is broken in a minor update, it should be fixed in a minor update, maybe even a bug update. If you release this in a major, people will update to the newest version automatically but not the newest major version, leaving their system broken.

auvipy · 2021-10-12T12:46:26Z

yes the release will be in A minor release

Luctia · 2021-10-13T17:59:22Z

Can this be merged soon? @jpadilla

jpadilla

@auvipy thanks, could you update version and changelog? 🙏

auvipy · 2021-10-14T07:05:37Z

yes sure allow me sometime. as you no i didnt want to merge this on first place :D will updte the changelogs and ping u

auvipy · 2021-10-15T05:46:37Z

@auvipy thanks, could you update version and changelog? pray

should that me on another PR?

Bumps [pyjwt](https://github.com/jpadilla/pyjwt) from 2.2.0 to 2.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jpadilla/pyjwt/releases">pyjwt's releases</a>.</em></p> <blockquote> <h2>2.3.0</h2> <h2>What's Changed</h2> <ul> <li>[pre-commit.ci] pre-commit autoupdate by <a href="https://github.com/pre-commit-ci"><code>@pre-commit-ci</code></a> in <a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/pull/700">jpadilla/pyjwt#700</a></li> <li>Add exception chaining by <a href="https://github.com/ehdgua01"><code>@ehdgua01</code></a> in <a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/pull/702">jpadilla/pyjwt#702</a></li> <li>Revert "Remove arbitrary kwargs." by <a href="https://github.com/auvipy"><code>@auvipy</code></a> in <a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/pull/701">jpadilla/pyjwt#701</a></li> <li>Bump up version to v2.3.0 by <a href="https://github.com/jpadilla"><code>@jpadilla</code></a> in <a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/pull/703">jpadilla/pyjwt#703</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/ehdgua01"><code>@ehdgua01</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/pull/702">jpadilla/pyjwt#702</a></li> <li><a href="https://github.com/auvipy"><code>@auvipy</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/pull/701">jpadilla/pyjwt#701</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/jpadilla/pyjwt/compare/2.2.0...2.3.0">https://github.com/jpadilla/pyjwt/compare/2.2.0...2.3.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst">pyjwt's changelog</a>.</em></p> <blockquote> <h2><code>v2.3.0 <https://github.com/jpadilla/pyjwt/compare/2.2.0...2.3.0></code>__</h2> <p>Fixed</p> <pre><code> - Revert "Remove arbitrary kwargs." `[#701](jpadilla/pyjwt#701) <https://github.com/jpadilla/pyjwt/pull/701>`__ <p>Added </code></pre></p> <ul> <li>Add exception chaining <code>[#702](jpadilla/pyjwt#702) <https://github.com/jpadilla/pyjwt/pull/702></code>__</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jpadilla/pyjwt/commit/98620ab2a396a5c887a494259d49552c2093e1ad"><code>98620ab</code></a> Bump up version to v2.3.0 (<a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/issues/703">#703</a>)</li> <li><a href="https://github.com/jpadilla/pyjwt/commit/f9db1d7b3acbe81daea7bc79cbc731f7c900221f"><code>f9db1d7</code></a> Revert "Remove arbitrary kwargs. (<a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/issues/657">#657</a>)" (<a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/issues/701">#701</a>)</li> <li><a href="https://github.com/jpadilla/pyjwt/commit/828a20a47ef7af5cddfe12b482a90df07cd1b323"><code>828a20a</code></a> Add exception chaining (<a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/issues/702">#702</a>)</li> <li><a href="https://github.com/jpadilla/pyjwt/commit/cf545e4bfc087e863b7c7a2a2313d52fe8f107ca"><code>cf545e4</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/issues/700">#700</a>)</li> <li>See full diff in <a href="https://github.com/jpadilla/pyjwt/compare/2.2.0...2.3.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pyjwt&package-manager=pip&previous-version=2.2.0&new-version=2.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

`v2.3.0 <https://github.com/jpadilla/pyjwt/compare/2.2.0...2.3.0>`__ Fixed ~~~~~ - Revert "Remove arbitrary kwargs." `openembedded#701 <https://github.com/jpadilla/pyjwt/pull/701>`__ Added ~~~~~ - Add exception chaining `openembedded#702 <https://github.com/jpadilla/pyjwt/pull/702>`__ Signed-off-by: Zang Ruochen <zangrc.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>

`v2.3.0 <https://github.com/jpadilla/pyjwt/compare/2.2.0...2.3.0>`__ Fixed ~~~~~ - Revert "Remove arbitrary kwargs." `#701 <https://github.com/jpadilla/pyjwt/pull/701>`__ Added ~~~~~ - Add exception chaining `#702 <https://github.com/jpadilla/pyjwt/pull/702>`__ Signed-off-by: Zang Ruochen <zangrc.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>

`v2.3.0 <https://github.com/jpadilla/pyjwt/compare/2.2.0...2.3.0>`__ Fixed ~~~~~ - Revert "Remove arbitrary kwargs." `openembedded#701 <https://github.com/jpadilla/pyjwt/pull/701>`__ Added ~~~~~ - Add exception chaining `openembedded#702 <https://github.com/jpadilla/pyjwt/pull/702>`__ Signed-off-by: Zang Ruochen <zangrc.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>

… verify= argument Since the arbitrary/unused `**kwargs` can't quite be dropped (as jpadilla#657 would do) without a major version bump (as reverted in jpadilla#701), it's still a good idea to warn users if they are attempting to use contradictory arguments for the security-sensitive `verify=` argument.

… verify= argument (#742) Since the arbitrary/unused `**kwargs` can't quite be dropped (as #657 would do) without a major version bump (as reverted in #701), it's still a good idea to warn users if they are attempting to use contradictory arguments for the security-sensitive `verify=` argument.

`v2.3.0 <https://github.com/jpadilla/pyjwt/compare/2.2.0...2.3.0>`__ Fixed ~~~~~ - Revert "Remove arbitrary kwargs." `#701 <https://github.com/jpadilla/pyjwt/pull/701>`__ Added ~~~~~ - Add exception chaining `#702 <https://github.com/jpadilla/pyjwt/pull/702>`__ Signed-off-by: Zang Ruochen <zangrc.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>

Revert "Remove arbitrary kwargs. (#657)"

a4b3d50

This reverts commit 5fe7f2b.

auvipy requested a review from jpadilla October 12, 2021 06:32

jpadilla approved these changes Oct 13, 2021

View reviewed changes

auvipy merged commit f9db1d7 into master Oct 15, 2021

auvipy deleted the revert-657-remove-arbitrary-kwargs branch October 15, 2021 06:53

akx mentioned this pull request Mar 30, 2022

Raise DeprecationWarning for jwt.decode(verify=...) #742

Merged

akx mentioned this pull request Mar 30, 2022

Don't accept decode(..., algorithm=...) #446

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Remove arbitrary kwargs." #701

Revert "Remove arbitrary kwargs." #701

auvipy commented Oct 12, 2021

auvipy commented Oct 12, 2021

Luctia commented Oct 12, 2021

auvipy commented Oct 12, 2021

Luctia commented Oct 13, 2021

jpadilla left a comment

auvipy commented Oct 14, 2021

auvipy commented Oct 15, 2021

Revert "Remove arbitrary kwargs." #701

Revert "Remove arbitrary kwargs." #701

Conversation

auvipy commented Oct 12, 2021

auvipy commented Oct 12, 2021

Luctia commented Oct 12, 2021

auvipy commented Oct 12, 2021

Luctia commented Oct 13, 2021

jpadilla left a comment

Choose a reason for hiding this comment

auvipy commented Oct 14, 2021

auvipy commented Oct 15, 2021