Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 update CSS Schemas to include TW3.3+ 950 color variants #751

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

wolfspyre
Copy link
Contributor

expand the CSS profiles to include the 950 variants of colors added in TailwindCSS 3.3:

https://tailwindcss.com/blog/tailwindcss-v3-3#extended-color-palette-for-darker-darks

Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4c600e8
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/6589e5a973dc490008e922a1
😎 Deploy Preview https://deploy-preview-751--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther
Copy link
Owner

Happy to add these in, although I'm not so sure about some of this whitespace padding. The space before the '50' variant is particularly obtuse. I'm surprised Prettier isn't overriding that?

@jpanther jpanther added the enhancement New feature or request label Dec 22, 2023
@wolfspyre
Copy link
Contributor Author

an here I thot I was helping there, by aligning the values such that regardless of the value, or the previous values, they’d all line up when eyeballing..
this is your baby, I’m not tryin to be a pain.

is yer preference that the hyphens align vs the colons?

That’s simple enough. LMK and I’ll push a fix

@jpanther
Copy link
Owner

Thanks for updating the formatting, I'll merge this in.

@jpanther jpanther merged commit e876aa0 into jpanther:dev Dec 27, 2023
6 checks passed
@wolfspyre
Copy link
Contributor Author

Thanks for updating the formatting, I'll merge this in.

ABSOLUTELY. My INTENT is to be HELPFUL. I jus occasionally need a bit more guidance than one might assume.

embarassed look I'd never used prettier before.. I'd jus sorta assumed it was being managed in CI..

having looked at it now a bit, I'm not sure how I feel about it... I haz opinions about some of the things it does to one's code layout... but ¯\_(ツ)_/¯ I'll deal with that when I have practical examples to articulate my opinion.

...One of the "joys" of having a bit of a weird brain ;)

@wolfspyre wolfspyre deleted the twcss33_950Vals branch April 24, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants