The plugin does not work

[dominikduda]

So I installed the plugin via plug.

Entering .graphql file and it looks as follows (no syntax highlight):

Did I forget something?

[jparise]

What is the output of the set filetype? command? And which version of vim are you running?

[dominikduda]

Result of vim -v:

NVIM v0.2.3-dev
Build type: RelWithDebInfo
Lua 5.1
Compilation: /usr/bin/x86_64-linux-gnu-gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -O2 -g -DMIN_LOG_LEVEL=3 -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/build/config -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/src -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/.deps/usr/include -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/.deps/usr/include -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/.deps/usr/include -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/.deps/usr/include -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/.deps/usr/include -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/.deps/usr/include -I/usr/include -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/build/src/nvim/auto -I/build/neovim-zQXPat/neovim-0.2.2ubuntu2+git201802042016-0851057-f2f288d/build/include
Compiled by buildd@lcy01-amd64-017

Features: +acl +iconv +jemalloc +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

[jparise]

I can't reproduce your problem using VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Mar 2 2018 02:50:34) or NVIM v0.2.2. I'm afraid you'll need to investigate further or provide more detail.

[johnelliott]

I think it would be great to put in the README something saying what the file extension should be and under what circumstances the user should expect highlighting or other behavior. I've had this installed for months and it's never once worked because I expected it to work like JSX and somehow find the graphql syntax amongst my JS. Then I forgot about the plugin.

Evidently from this screenshot that's not how it works. I just now did a comand-F on the github page and searched .graphql and found a snippet of a commit message that let me to the fdetect files. I knew nothing about these until just now.

Perhaps users should read the spec or the source to understand the above, but they are probably not going to do that 🤷‍♂️ and a little hand-holding might get more people to use this.

[jparise]

That's good feedback, @johnelliott. I added some more README.md documentation in c917029 and f655336 that hopefully makes the plugin's file detection and JavaScript syntax support more clear.

In terms of this issue, I see from the screenshot that @dominikduda has loaded a file with a .graphql extension, so it should have automatically selected the graphql filetype. That's also why I originally asked about the output of set filetype?, which would verify whether or not the buffer's filetype was set as expected.

[johnelliott]

@jparise looks great now. There’s no missing it.

I’ll try this out this week. I’m not totally sure if my team will end up using files with a bare query in them. At the moment we tend to use them as JavaScript template literals with substitution so they don’t end up being a .gql file. It’s usually wrapped with JavaScript.

[jparise]

@johnelliott, that workflow is also supported if you use e.g. an ES6 gql tag.

Unfortunately, you'll need to also install the vim-javascript plugin because vim's built-in JavaScript syntax doesn't specifically recognized tagged template literals.

[jparise]

Closing this due to lack of information. Please open when you have more details.