Revise {java,type}scriptreact filetype support #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously supported JSX and TSX files using compound (dotted) filetypes. Vim 8.2 also introduced distinct 'javascriptreact' and 'typescriptreact' filetypes, so support them as well. This also removes support for the dedicated 'tsx' filetype. We now specifically support both 'typescript.tsx' and 'typescriptreact', so that should cover everyone's use case. For our purposes, all of these extended filetypes simply load the underlying 'javascript' or 'typescript' syntax support we already provide.
jparise
force-pushed
the
react-filetypes
branch
from
c6cbf3f
to
2105871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously supported JSX and TSX files using compound (dotted)
filetypes. Vim 8.2 also introduced distinct 'javascriptreact' and
'typescriptreact' filetypes, so support them as well.
This also removes support for the dedicated 'tsx' filetype. We now
specifically support both 'typescript.tsx' and 'typescriptreact', so
that should cover everyone's use case.
For our purposes, all of these extended filetypes simply load the
underlying 'javascript' or 'typescript' syntax support we already
provide.