Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seen Command, Timestamp and Balance integrity #5

Closed
jpcsupplies opened this issue Aug 24, 2015 · 7 comments
Closed

Seen Command, Timestamp and Balance integrity #5

jpcsupplies opened this issue Aug 24, 2015 · 7 comments

Comments

@jpcsupplies
Copy link
Owner

along with uid and balance, a timestamp should also be recorded in the balance file.

this timestamp is also used to prevent players with 0 balance accidentally being given another "default balance" if we have not allowed for this already when adding new players to the balance file (actually the way file works now this shouldn't happen now anyway)

this time stamp should be added/updated every time someone uses an economy command - although it could also be updated on QUIT too - it should only update if they already HAVE a bank balance so as to not conflict with our database minimization strategy.

A seen command that displays this timestamp would also be useful.

@jpcsupplies jpcsupplies added this to the Pre-alpha release milestone Aug 24, 2015
@jpcsupplies jpcsupplies changed the title Timestamp and Balance integrity Seen Command, Timestamp and Balance integrity Sep 3, 2015
@jpcsupplies
Copy link
Owner Author

Looking at the /bal code we need to make it update the timestamp if there is already a balance too

jpcsupplies added a commit that referenced this issue Sep 10, 2015
added a seen command as listed in issue #5, still need to update current
user timestamp
@jpcsupplies
Copy link
Owner Author

Have a working seen command now, just need to add in some quick code so that the timestamp updates on execution of any other command.

Is there any obvious way to catch a quit event too? That would be the better place to catch a timestamp.

@midspace
Copy link
Collaborator

I've standardized the Seen update in 15cc91a

It does not check the balance though.
I'm thinking it might be backwards if we don't update the date seen if they have no balance.
They might have just sold something, and are waiting on the dough.

@jpcsupplies
Copy link
Owner Author

hmm well the idea is to keep the database size small, any player not using the economy isnt in the database, to avoid revolving door noobs who join for 5 seconds and never return getting a balance, although from a practical sense catching the quit event for a timestamp is intiutve to what people expect a seen command to do :/

@midspace
Copy link
Collaborator

Perhaps adding FirstSeen or DateJoined, so we know how long they have been active for.

@jpcsupplies
Copy link
Owner Author

sort of like an account opened date ?
that could work, could even display it in the /accounts command output

@jpcsupplies jpcsupplies removed this from the Pre-alpha release milestone Sep 12, 2015
midspace added a commit that referenced this issue Sep 19, 2015
Added OpenedDate and Language properties to the Bank Account.
They are updated correctly by the Seen event.
@jpcsupplies
Copy link
Owner Author

Added seen date to accounts command. pretty much everything we can do here is done i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants