Android: Fix controller input causing screen highlight #1259
Conversation
…f the emulator SurfaceView
|
@jpd002 not sure if this is how you want to ultimately implement this fix. The issue is that the SurfaceView is becoming highlighted as Android is, by default, focusing on the view when a user uses a controllers D-pad. The option to disable this behaviour is only available since API 26. There might be a better way to fix this so it works for all API level's? But I'm not an Android dev! |
|
Would it work if we applied this on the SurfaceView only instead of applying it broadly on the theme? I'm not sure if there's gonna be side effects of applying it globally like that. Thanks! |
- Change from overriding the entire style to adding an override for the specific view
|
why not add that directly to the emulator.xml? (yes im aware this was only added for api 26, but wouldnt it just be ignored on older versions?) |
|
Will give it a try and update :) |
|
@jpd002 @Zer0xFF changed to just add attibute in required view. Android does indeed ignore unsupported XML attributes |
| @@ -37,7 +38,7 @@ | |||
| android:id="@+id/emulator_profile" | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:layout_gravity="right" | |||
| android:layout_gravity="end" | |||
There was a problem hiding this comment.
Is this an intentional change? If not, probably best to leave it out.
There was a problem hiding this comment.
Argh sorry about that! Changed it back now
|
Thanks for this! |
ghost
deleted the
|
Just tried the latest build and working perfectly! Thank you for merging it! |
Fixes: #1089
Fix an issue on Android where input from a controller would cause the SurfaceView to become highlighted