Build libretro core for iOS #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmenhoven
force-pushed
the
warmenhoven/pr/libretro-ios
branch
from
e82d1be
to
2688509
Compare
jpd002
reviewed
Mar 5, 2024
warmenhoven
force-pushed
the
warmenhoven/pr/libretro-ios
branch
from
2688509
to
d8360da
Compare
|
Thanks for this! Yeah, the |
jpd002
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the flycast core, I've added a check that retroarch does on iOS to see if JIT is likely to work, and fail to load the game if JIT is not enabled.
In order to pick up that environ flag, I had to pull in a newer version of libretro.h. There shouldn't be any functional change, but the diff looks abnormally large because 1) it's been a while and 2) it looks like there was code style formatting applied to the play! version?