Aux spi port and roll-up other PRs #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
primary port equivalents and changed their name. Added the flag WORKER_ENABLED to permit running in newer NODE releases easier, but I have not verified if the code can actully do multi-threading. A quick glance indicates most register access are benign, but if two processes seperately start to access a SPI port results may be suprising.
…#154 rather than assume /proc/device-tree/model This allows non privileged docker containers to specify a different path for the model file since it can't use /proc/device-tree/model
|
Thanks! A lot of this looks great, sorry that I've been swamped for a while. I'll try to get to this as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR of my aux_spi changes, as well as other PR's submitted over the last 3 years.
Included are :
Update nan to min 2.18.0
Update readme with confirmed working node versions
Add node 16/18 to previous LTS testing
Update to NodeJS 15 and 16
feat: adding support for device_tree_path in rpio.init to fix #154
Added proper pinmap detection for BPI-M2P Zero 40pin
Added support for driving the aux-spi port.
Ultimately, I intend to push this to the node npm repository as a package under a scoped public name '@remarkablearts/rpio allowing easy inclusion of these updates .
Of course, J Perkin can merge this (or the other PRs independently) and npm should pick up the new version as well. but until then, the scoped package will be available.
NOTE - I did not test the changes except for the AUX_SPI stuff I contributed. Examining the code, they seem to do what the authors intended, but not verified by me.