Coding Standards - Linting #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstml
force-pushed
the
audit/shellcheck
branch
from
f2fcf6a
to
c12ef1b
Compare
Open
cstml
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poor-code-standardsDescription
Use shellcheck to perform static analysis of the
shellscripts used in the offchain of the protocol to find optimisations, and underlying bugs. Usehlintto lint the Haskell code.Vulnerabilities
Please refer to ./docs/audit/shell-check-report.txt for a detailed list of all the bugs, vulnerabilities, and optimisations. Note that the
shellcheckanalysis is based on the assumption that the scripts are intended to be interpreted via/bin/bash.Please refer to ./docs/audit/hlint-check-report.txt for linting suggestions.