Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract Driven Development Feedback #24

Closed
jpgough opened this issue Sep 17, 2019 · 1 comment
Closed

Contract Driven Development Feedback #24

jpgough opened this issue Sep 17, 2019 · 1 comment
Assignees
@Budlee
Labels
enhancement New feature or request presentation Presentation Materials

Comments

@jpgough
Copy link
Owner

jpgough commented Sep 17, 2019

  • a Mixture of examples, Pizza/Google. Should we just center on the todo service? I think that will lead nicer into the lab.
  • It’s not so clear when we are moving between Spring Cloud Contract and pact. I’m wondering if the flow would work better as Producer driven contracts with diagrams, and the technology. Followed by what’s a consumer driven contract and how does that differ with a diagram.
  • Missing conversation on stub server/broker and how that leads to more effective team collaboration
@jpgough jpgough added enhancement New feature or request presentation Presentation Materials labels Sep 17, 2019
@Budlee
Copy link
Collaborator

Budlee commented Sep 17, 2019

Add a note that the ContractBase should go into the test folder and NOT in main

@Budlee Budlee changed the title Contract Driven Development Slide Feedback Contract Driven Development Feedback Sep 17, 2019
Budlee added a commit to Budlee/api-workshop that referenced this issue Sep 18, 2019
@Budlee
Issue jpgough#24 Changes to presentation to fix order of producer and…
bab3c69 
… consmer and remove Pizza and Google references
Budlee added a commit to Budlee/api-workshop that referenced this issue Sep 18, 2019
@Budlee
Issue jpgough#24 adding in new Broker slide
07b7046
@Budlee Budlee mentioned this issue Sep 18, 2019
Merged
Budlee added a commit that referenced this issue Sep 19, 2019
@Budlee
Contract testing fixes (#32)
eab3c46 
* Update README for the TODO

* Issue #24 Changes to presentation to fix order of producer and consmer and remove Pizza and Google references

* Issue #24 adding in new Broker slide
@jpgough jpgough closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Budlee Budlee

Labels
enhancement New feature or request presentation Presentation Materials
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpgough @Budlee