avoid plain-text proxy password - read from terminal / input #361
Conversation
|
@jpillora could you merge this please? thanks! |
| pass, _ := u.User.Password() | ||
| if pass == "" { | ||
| fmt.Print("*** Enter proxy password: ") | ||
| if term.IsTerminal(syscall.Stdin) { |
There was a problem hiding this comment.
Does terminal case differ from the read line case?
There was a problem hiding this comment.
TBH I'm not sure what the difference is (not a GO programmer...).
But when I tried this with just terminal (i.e. just the "if" part w/o else), and I tried to pass the proxy password using pipe:
echo some_password | chisel client ....
I got this error:
client: Connection error: inappropriate ioctl for device
When I googled the issue I found this thread, and the suggested solution worked: golang/go#19909 (comment)
See also here:
golang/go#19909 (comment)
|
Thanks but i've decided to close this as this feature has the potential to conflict with the |
Following up on this issue: #340
Added a way to avoid plain text proxy passwords: you can run chisel client with --proxy user:@<proxy_ip>, and you will be prompt for a password.
alternatively, you can pass the password to chisel this way using pipe.