[Bug] Windows locks executing files

[krzysztofantczak]

Hi,

It seems that something is wrong with the way it works under windows. When its trying to move a file:

The process cannot access the file because it is being used by another process

Any ideas how can i fix it?

[jpillora]

Sorry, I didn't add the Windows support so I'm unable to help!
On Mon, 9 May 2016 at 6:44 PM Krzysztof Antczak notifications@github.com
wrote:

Hi,

It seems that something is wrong with the way it works under windows. When
its trying to move a file:

The process cannot access the file because it is being used by another process

Any ideas how can i fix it?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#7

[tgulacsi]

@krzysztofantczak Windows locks executing files, so I don't know an easy solution. Maybe same black-magic dancing with renames and copies could work:
0. Assume we've been started as a.exe

1. download as a-upd.exe
2. try to execute a-upd.exe with OVERSEER_BIN_UPD env var (see "sanity check")
3. exec (replace current process with the new one - if such exists in Windows) a-upd.exe with some env param to notify this is an intermediate step;
4. in this intermediate step, copy a-upd.exe to a.exe
5. exec a.exe

(AFAIK now steps 1, 2, 5 are in action).

[elvarb]

Moving a file is impossible, but it is possible to rename the running file. Solving this would always requiring restarting the process.

1. Rename bin.exe to bin_oldver.exe
2. Download new bin to bin.exe
3. Restart running bin.exe with the new bin.exe

[hellowzsg]

Problems solved( rename), if still doesn't work, make sure the src and dst in the same disk drive.
You can Modify like this，
https://github.com/tgulacsi/overseer/blob/fcf3e6b7d6c0cb9097be23e7191459e68b6a5f1b/proc_master.go#L22
var tmpBinPath = filepath.Join(os.TempDir(), "overseer-"+token()) ==>
var tmpBinPath = filepath.Join("./", "overseer-"+token())

But, there is another problems , the go(1.18) is not support for fileconn in window. https://github.com/golang/go/issues/9503