Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release process #136

Closed
10 tasks done
jpillora opened this issue Jul 10, 2022 · 10 comments
Closed
10 tasks done

Automate release process #136

jpillora opened this issue Jul 10, 2022 · 10 comments

Comments

@jpillora
Copy link
Owner

jpillora commented Jul 10, 2022

  • create a main branch and set it as the default branch
  • delete dist/ and other build files from main
  • keep gh-pages static hosting for direct imports
  • set main's package.json file version to "0.0.0-git-tag"
  • add a GHA workflow which will run on tag, which will
    • modify package.json version to the current tag
    • run npm build
    • push all files to gh-pages AND
    • run npm publish
  • use GH releases to formally (tag and) release this library
@jpillora
Copy link
Owner Author

Hey @TrickyPi thanks for volunteering for this one! I added you as collaborator too :)

@TrickyPi
Copy link
Collaborator

Yeah, I received an invite link, it's so exciting

@TrickyPi
Copy link
Collaborator

TrickyPi commented Jul 12, 2022

add a GHA workflow which will run on tag, which will

modify package.json version to the current tag

Could we change the package version in local? it is more convenient to control the version, for example

npm version major | minor | patch

we can then push the tag to the remote registry to activate the GHA workflow.

@TrickyPi
Copy link
Collaborator

It's time to release 1.5.0?

@jpillora
Copy link
Owner Author

I think we need to delete the v,
Or update the replace to drop the v?

Then can tag “1.5.0”

@jpillora
Copy link
Owner Author

add a GHA workflow which will run on tag, which will

modify package.json version to the current tag

Could we change the package version in local? it is more convenient to control the version, for example

npm version major | minor | patch

we can then push the tag to the remote registry to activate the GHA workflow.

Sorry I missed this one, npm version does a package json edit, direct commit and tag which doesn’t work well with a PR process

so we’ll instead just tag, and automate the rest from there

@TrickyPi
Copy link
Collaborator

TrickyPi commented Jul 17, 2022

I think we need to delete the v, Or update the replace to drop the v?

Then can tag “1.5.0”

Will it cause some trouble?
I saw many repos use v as the version prefix in git.

@jpillora
Copy link
Owner Author

Ah slice from index 1, missed that sorry

@jpillora
Copy link
Owner Author

image

publish failed, weird since the secret is there...

@TrickyPi
Copy link
Collaborator

TrickyPi commented Jul 17, 2022

Oh, I forget to configure registry-url for action/setup-node@v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants