-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
?url
and ?raw
suffix support
#21
Conversation
Using `?url` suffix to explicit URL Imports, or `?raw` sudffix to import .svg as string.
Thanks @Thy3634 |
@Thy3634 Could you run the linter over your code? |
linked now
Failed. So I add a submit, and the code could be linted over now. |
There are still some lint errors:
|
Maybe git ignored something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've placed some comments. Could you review them?
Thanks for your changes! I've added 1 comment. |
Thanks for your work 👍 |
This PR breaks |
@CzBiX Could you explain what exactly breaks? |
@jpkleemans, When I write code like this: import SvgIcon from 'foobar/demo.svg?url'
console.log(SvgIcon) It will output the local path of file, like I hacked the code to return |
Using
?url
suffix to explicit URL Imports,as well as
?raw
suffix to import .svg file as string.#20 by gawlk