Fix warnings on Windows and reimplement err and errx as functions #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingw-w64's stdio.h header already defines fseeko Signed-off-by: Christopher Degawa <ccom@randomderp.com>
gcc warns against comparing size_t against -1 or checking if it's less than zero as the first may be due to incorrect assumptions and the second will always return false. Signed-off-by: Christopher Degawa <ccom@randomderp.com>
These functions are based on the manpage for err(3) and errx(3), minus the condition for the fmt to be NULL on the consideration that none of the calls to them contain NULL as the fmt. Online man page that was consulted: https://docs.oracle.com/cd/E36784_01/html/E36874/errx-3c.html Signed-off-by: Christopher Degawa <ccom@randomderp.com>
1480c1
commented
Oct 28, 2022
Comment on lines
+50
to
+51
| #include <errno.h> | ||
| #include <stdarg.h> |
There was a problem hiding this comment.
If wanted, I can move these includes up to an else branch for the #if !defined(WIN32) && !defined(_AIX) condition. I've only included them here for no particular reaso
1480c1
commented
Oct 28, 2022
Comment on lines
+78
to
81
| #if defined(_WIN32) && !defined(fseeko) | ||
| # define fseeko fseek | ||
| # define ftello ftell | ||
| #endif |
There was a problem hiding this comment.
A potentially more robust check would be to also add && !defined(ftello) and undef both before defining them, but I wasn't sure if adding more lines for these two macros would be desirable
|
This looks good to me for Darwin, Debian 11, and MingW (gcc 9.2.0) on Windows10. Thank you for your help and contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #192
Fixes some warnings produced by mingw-w64 gcc regarding signed<->unsigned comparison and comparing against less than 0 for unsigned numbers, along with redefined macros.
Also reimplements the macros err and errx as functions based on the man page description, minus a few sections due to those conditions not being met in any of the calls.
Confirmed this to work on both linux with
gcc (GCC) 12.2.0andx86_64-w64-mingw32-gcc (GCC) 12.2.0from archlinux and fromcc.exe (Rev4, Built by MSYS2 project) 12.2.0from ucrt64 from MSYS2.To reproduce on a linux machine with mingw-w64 gcc and meson installed