Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular respects .gitignore & .modularignore #2391

Merged
merged 7 commits into from
May 19, 2023

Conversation

AlbertoBrusa
Copy link
Contributor

Workspace resolver will respect .gitignore, overridden by .modularignore if provided

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023

🦋 Changeset detected

Latest commit: 034cc29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
modular-scripts Major
@modular-scripts/workspace-resolver Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlbertoBrusa AlbertoBrusa marked this pull request as ready for review May 17, 2023 14:08
@coveralls
Copy link
Collaborator

coveralls commented May 17, 2023

Coverage Status

Coverage: 43.943% (+0.07%) from 43.868% when pulling 034cc29 on AlbertoBrusa:modular-ignore into 7a7c247 on jpmorganchase:feature/v5.0.

@AlbertoBrusa AlbertoBrusa merged commit a5a0372 into jpmorganchase:feature/v5.0 May 19, 2023
@github-actions github-actions bot mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants