Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Spinner from lab to core; create Spinner documentation #1184

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Move Spinner from lab to core; create Spinner documentation #1184

merged 2 commits into from
Feb 22, 2023

Conversation

libertymayc
Copy link
Contributor

@libertymayc libertymayc commented Feb 22, 2023 •
edited
Loading

  • Spinner docs
  • Move Spinner to core

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d70fde5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@salt-ds/core Minor
@salt-ds/lab Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023 •
edited
Loading

Site Preview Link https://7f7d957a.saltdesignsystem.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023 •
edited
Loading

Storybook Preview Link https://43c0b353.saltdesignsystem-storybook.pages.dev

@libertymayc libertymayc changed the title Move Spinner from lab to core Move Spinner from lab to core; create Spinner documentation Feb 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023 •
edited
Loading

Site Storybook Preview Link https://ec34c4f7.saltdesignsystem-site-storybook.pages.dev

@libertymayc libertymayc force-pushed the spinner-2 branch 3 times, most recently from 1131875 to 8dfec4e Compare February 22, 2023 12:41
@libertymayc libertymayc merged commit b1c5c32 into main Feb 22, 2023
@libertymayc libertymayc deleted the spinner-2 branch February 22, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fercas123 Fercas123 Fercas123 left review comments

@alycrys alycrys alycrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@libertymayc @alycrys @Fercas123