Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pill characteristic usage #144

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Pill characteristic usage #144

merged 4 commits into from
Jun 28, 2022

Conversation

libertymayc
Copy link
Contributor

@libertymayc libertymayc commented Jun 1, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Latest commit: f22d3f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@jpmorganchase/uitk-lab Minor
@jpmorganchase/uitk-theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 1, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f22d3f0
Status: ✅  Deploy successful!
Preview URL: https://c065d419.uitk.pages.dev
Branch Preview URL: https://pill-characteristics.uitk.pages.dev

View logs

heswell
heswell previously approved these changes Jun 7, 2022
@libertymayc libertymayc force-pushed the pill-characteristics branch 2 times, most recently from da7e889 to 1e15898 Compare June 9, 2022 09:24
@libertymayc libertymayc requested a review from heswell June 13, 2022 10:09
@joshwooding joshwooding marked this pull request as draft June 13, 2022 10:44
@libertymayc libertymayc marked this pull request as ready for review June 15, 2022 15:35
@origami-z
Copy link
Contributor

When using the keybaord "Space" on Selectable Pill, transition state is somewhat weird

https://79de1893.uitk.pages.dev/?path=/story/lab-pill--selectable-pill

@origami-z origami-z mentioned this pull request Jun 17, 2022
9 tasks
@libertymayc libertymayc changed the title pill consuming characteristics Pill characteristic usage Jun 17, 2022
@origami-z origami-z added this to the Kingsman Release milestone Jun 21, 2022
Copy link
Contributor

@heswell heswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget the changeset

heswell
heswell previously approved these changes Jun 22, 2022
@libertymayc libertymayc marked this pull request as draft June 22, 2022 16:04
@libertymayc libertymayc marked this pull request as ready for review June 23, 2022 14:27
@libertymayc libertymayc force-pushed the pill-characteristics branch 2 times, most recently from 6a952da to b91cf0d Compare June 23, 2022 14:28
origami-z
origami-z previously approved these changes Jun 24, 2022
@heswell heswell merged commit 50dcb9a into main Jun 28, 2022
@heswell heswell deleted the pill-characteristics branch June 28, 2022 08:03
joshwooding pushed a commit that referenced this pull request Aug 25, 2022
* Pill styling; consuming characteristics; docs

* Improvements and fixes to Pill.css

* Update red-peas-invent.md

Co-authored-by: Zhihao Cui <davidcui2@me.com>
Co-authored-by: heswell <steve@heswell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants