-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for Lab/Badge #194
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for contributing! some changes requested - see comments
Thank you for your review! Sorry for any silly mistakes as I'm a first-time contributor. |
I think I did something wrong, suddenly there are merge conflicts on my branch. Is this normal? |
You just need to rebase on the main branch, as there have been some changes today :) |
fix Lab/Badge description wording fix Lab/Badge custom styling theme
@LeoLYW12138 Thanks for the contribution. In case the CLA process is not clear for you (the label I added) We requrie all contributors to JPMC projects to complete our Contribution Licence Agreement (CLA). You can sign as an individual or as representing your company. You only need to do this once and it covers all current and future projects managed under our GitHub organization. The contribution agreement can be found here JPMC CLA, follow the instructions to complete and return to opensource_cla@jpmorgan.com |
Sorry for the inconvenience but I have signed the CLA and returned to opensource_cla@jpmorgan.com through email on Friday noon GMT+8. However, there is no response or further notice. |
I will chase up and get this merged ASAP. Thank you for the patience. 👍 |
emm... Any update on this? I am ok to sign the CLA again if the previous one was not recorded. |
CLA is handled by a different team. I have chased up again. |
Notes for the team: we need to figure out a way to run Chromatic on forked PRs. Merging this now, looks fine locally. |
Add doc page for Lab/Badge component as requested by #161