Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for Lab/Badge #194

Merged
merged 11 commits into from
Jun 22, 2022
Merged

Conversation

LeoLYW12138
Copy link
Contributor

Add doc page for Lab/Badge component as requested by #161

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2022

⚠️ No Changeset found

Latest commit: ea35134

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@libertymayc libertymayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for contributing! some changes requested - see comments

@LeoLYW12138
Copy link
Contributor Author

Thank you for your review! Sorry for any silly mistakes as I'm a first-time contributor.

@LeoLYW12138
Copy link
Contributor Author

I think I did something wrong, suddenly there are merge conflicts on my branch. Is this normal?

@libertymayc
Copy link
Contributor

I think I did something wrong, suddenly there are merge conflicts on my branch. Is this normal?

You just need to rebase on the main branch, as there have been some changes today :)

fix Lab/Badge description wording

fix Lab/Badge custom styling theme
@origami-z origami-z added the CLA: Pending Pending confirmation of signing CLA label Jun 16, 2022
@origami-z
Copy link
Contributor

@LeoLYW12138 Thanks for the contribution. In case the CLA process is not clear for you (the label I added)

We requrie all contributors to JPMC projects to complete our Contribution Licence Agreement (CLA). You can sign as an individual or as representing your company. You only need to do this once and it covers all current and future projects managed under our GitHub organization.

The contribution agreement can be found here JPMC CLA, follow the instructions to complete and return to opensource_cla@jpmorgan.com

@origami-z origami-z mentioned this pull request Jun 20, 2022
45 tasks
@LeoLYW12138
Copy link
Contributor Author

Sorry for the inconvenience but I have signed the CLA and returned to opensource_cla@jpmorgan.com through email on Friday noon GMT+8. However, there is no response or further notice.

@origami-z
Copy link
Contributor

I will chase up and get this merged ASAP. Thank you for the patience. 👍

@LeoLYW12138
Copy link
Contributor Author

emm... Any update on this? I am ok to sign the CLA again if the previous one was not recorded.

@origami-z
Copy link
Contributor

CLA is handled by a different team. I have chased up again.

@origami-z origami-z added CLA: Received CLA has been received and removed CLA: Pending Pending confirmation of signing CLA labels Jun 22, 2022
origami-z
origami-z previously approved these changes Jun 22, 2022
@origami-z origami-z changed the title add doc for Lab/Badge Add doc for Lab/Badge Jun 22, 2022
@origami-z
Copy link
Contributor

Notes for the team: we need to figure out a way to run Chromatic on forked PRs. Merging this now, looks fine locally.

@origami-z origami-z merged commit 14a19d6 into jpmorganchase:main Jun 22, 2022
@origami-z origami-z added this to the Kingsman milestone Jun 23, 2022
joshwooding pushed a commit that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Received CLA has been received
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants