Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Accordion to Core #235

Closed
wants to merge 11 commits into from
Closed

Move Accordion to Core #235

wants to merge 11 commits into from

Conversation

alycrys
Copy link
Contributor

@alycrys alycrys commented Jun 29, 2022

A component is complete and ready for consumption (moved to core) when all the following are checked:

  • Stories for all features/variations
  • Add QA story
  • Add Custom styling story
  • Jest tests migrated to Cypress
  • Tests added for all features/variations
  • Check CSS variables (characteristic/foundation/token etc) are used correctly
  • ADA review done

Docs added:

  • Props table
  • HTMxL anatomy
  • CSS class
  • Characteristics used
  • Custom property API
  • Customising styles

Migrating tips:

  • Mention breaking changes
  • Any useful advice or mention

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2022

⚠️ No Changeset found

Latest commit: 8eb4e46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 29, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8eb4e46
Status: ✅  Deploy successful!
Preview URL: https://ccbc0014.uitk.pages.dev
Branch Preview URL: https://accordion-qa-story.uitk.pages.dev

View logs

@origami-z origami-z mentioned this pull request Jul 1, 2022
5 tasks
@alycrys alycrys self-assigned this Jul 1, 2022
@joshwooding
Copy link
Contributor

Closing this for now since Accordion isn't high priority.

@libertymayc libertymayc deleted the accordion-qa-story branch February 24, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants