Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editable cell in ag-grid-theme #2906

Merged
merged 21 commits into from
Jan 31, 2024
Merged

Fix editable cell in ag-grid-theme #2906

merged 21 commits into from
Jan 31, 2024

Conversation

alycrys
Copy link
Contributor

@alycrys alycrys commented Jan 12, 2024

Fixed missing padding and focus ring on focused editable cell.
Fixed wrong background and missing corner flag when editable cell loses focus.

Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: 3c68a7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/ag-grid-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 4:13pm

@alycrys alycrys changed the title Editable cell bug Fix editable cell bug in ag-grid-theme Jan 12, 2024
Copy link
Contributor

github-actions bot commented Jan 12, 2024

Storybook Preview Link https://5e94f528.saltdesignsystem-storybook.pages.dev

@alycrys
Copy link
Contributor Author

alycrys commented Jan 12, 2024

/release-pr

Copy link
Contributor

🫰✨ Thanks @alycrys! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/ag-grid-theme@0.0.0-snapshot-20240112135403
yarn add @salt-ds/core@0.0.0-snapshot-20240112135403
yarn add @salt-ds/lab@0.0.0-snapshot-20240112135403
yarn add @salt-ds/theme@0.0.0-snapshot-20240112135403

@alycrys alycrys changed the title Fix editable cell bug in ag-grid-theme Fix editable cell in ag-grid-theme Jan 12, 2024
origami-z
origami-z previously approved these changes Jan 15, 2024
@alycrys alycrys changed the title [WIP] Fix editable cell in ag-grid-theme Fix editable cell in ag-grid-theme Jan 22, 2024
origami-z
origami-z previously approved these changes Jan 23, 2024
@alycrys alycrys merged commit f167c14 into main Jan 31, 2024
15 checks passed
@alycrys alycrys deleted the editable-cell-bug branch January 31, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants