Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker updates #3538

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Picker updates #3538

merged 10 commits into from
Jun 13, 2024

Conversation

Fercas123
Copy link
Contributor

@Fercas123 Fercas123 commented Jun 10, 2024

change picker to use generic types and add controlled stories

input changes:

  • exposed start and end date in onChange

picker

  • removed startDate, defaultStartDate, setStartDate, endDate, defaultEndDate, setEndDate
  • added selectedDate, defaultSelectedDate, setSelectedDate

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 2:30pm

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: 35fd928

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/lab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/mean-worms-brake.md Outdated Show resolved Hide resolved
packages/lab/src/date-input/DateInput.tsx Outdated Show resolved Hide resolved
origami-z
origami-z previously approved these changes Jun 13, 2024
Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we double check whether new props are all captured in the changelog?

@Fercas123 Fercas123 merged commit ba1dc07 into main Jun 13, 2024
15 checks passed
@Fercas123 Fercas123 deleted the picker-example branch June 13, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants