Skip BinLogTest on OSX for Java 9 and newer due to fcntl(fd, F_FULLSYNC) being slow. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NC) being slow. Note: Java 8 and older does not use fcntl(fd, F_FULLSYNC) and won't fully flush buffers to disk.
|
That's a very good finding that deserves an issue report so we can investigate how to work around this issue in Java 9 and newer in OSX. If we just ignore the problem, then BinLog would become dangerous to use or could cause a slowdown at runtime. Can you add it and link it to this PR? I'm OK to merge the PR once the issue is there, so that we don't forget about it. |
|
Opened issue #153. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Java 8 and older does not use fcntl(fd, F_FULLSYNC) and won't fully flush buffers to disk.
See: AdoptOpenJDK/openjdk-jdk9@4449192